Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ui-lib #1

Draft
wants to merge 2 commits into
base: parcel
Choose a base branch
from
Draft

Adds ui-lib #1

wants to merge 2 commits into from

Conversation

necoline
Copy link

I'm not sure if this should be a standalone option or part of the parcel branch. I think it depends on the extent to which we want to maintain these (parcel and browserify) branches as 'minimal config templates'.

I have had a few requests in the past for a ui-lib app template and I thought this would be an ideal way to offer a no-fuss application spin-up for folks on other teams when they need to create very simple interfaces

AliceR
AliceR reviewed Apr 27, 2021
View reviewed changes
{{cookiecutter.project_slug}}/.nvmrc
@@ -1 +1 @@
14
14.15.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems very specific. Is there a reason for it?

@AliceR
Copy link
Member

AliceR commented Apr 27, 2021

Nice addition!! 🚀

Things I noticed, which apply to all the cookiecutter branches:

  • we should rename the default branch that is created. Currently master, I'd suggest develop
  • Maybe we should run yarn install after initialization (add step in post_gen_project.py)?
  • I got this warning:

@parcel/transformer-babel: It looks like you're using a JavaScript Babel config file. This means the config cannot be watched for changes, and Babel transformations cannot be cached. You'll need to restart Parcel for changes to this config to take effect. Try using a babel.config.json file instead.

  • the mapbox token is missing initially. I wonder how we can improve the dev experience around that, just a blank screen does not help (the console gives a clue though). Ask for the token in cli when creating the project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliceR AliceR AliceR left review comments

@vgeorge vgeorge Awaiting requested review from vgeorge

@danielfdsilva danielfdsilva Awaiting requested review from danielfdsilva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@necoline @AliceR